Skip to content

chore: split linters per filetype#6450

Merged
LesnyRumcajs merged 2 commits intomainfrom
rubocop-only-ruby-scripts
Jan 21, 2026
Merged

chore: split linters per filetype#6450
LesnyRumcajs merged 2 commits intomainfrom
rubocop-only-ruby-scripts

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Jan 20, 2026

Summary of changes

Changes introduced in this pull request:

  • split linters per filetype; this should decrease CI times. No need to check Ruby or Python scripts that are modified maybe once a year.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Refactored CI/CD linting infrastructure by splitting the consolidated linting workflow into separate, language-specific workflows for Docker, Python, Ruby, shell scripts, YAML, and list formatting to improve maintainability and parallel execution.

✏️ Tip: You can customize this high-level summary in your review settings.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 20, 2026 12:37
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team January 20, 2026 12:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 20, 2026

Walkthrough

The PR refactors the CI linting workflow structure by splitting a monolithic scripts-lint.yml into six separate, language-specific workflows. Each new workflow (docker-lint, lists-lint, python-lint, rubocop, shellcheck, yaml-lint) handles linting for its respective language or file type with individual concurrency control and path-based triggers.

Changes

Cohort / File(s) Summary
New individual linter workflows
.github/workflows/docker-lint.yml, .github/workflows/lists-lint.yml, .github/workflows/python-lint.yml, .github/workflows/rubocop.yml, .github/workflows/shellcheck.yml, .github/workflows/yaml-lint.yml
Six new workflows created to handle linting for Docker, lists, Python, Ruby, shell scripts, and YAML respectively. Each defines concurrency control, path-based triggers on main branch, and runs corresponding linting tools via mise-action or direct installation.
Removed combined workflow
.github/workflows/scripts-lint.yml
Deleted monolithic workflow that previously orchestrated shellcheck, rubocop, python-lint, docker-lint, yaml-lint, and lists-lint jobs in a single file. Includes removal of multi-job coordination, conditional execution logic for gh-readonly-queue branches, and consolidated linting configurations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

github_actions

Suggested reviewers

  • hanabi1224
  • akaladarshi
  • sudo-shashank
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: split linters per filetype' directly describes the main change: the pull request refactors the CI linting workflow by splitting a single monolithic linting workflow into separate language-specific workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 5c2d596 Jan 21, 2026
42 checks passed
@LesnyRumcajs LesnyRumcajs deleted the rubocop-only-ruby-scripts branch January 21, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants